-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass large interpreter types by reference, not value #82124
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 2f848d16c713221f16669cdc9f26e3475f0e853f with merge 0e02f3685d46b23771eab0f3e32ad5c642674b72... |
This comment has been minimized.
This comment has been minimized.
☀️ Try build successful - checks-actions |
Queued 0e02f3685d46b23771eab0f3e32ad5c642674b72 with parent 9503ea1, future comparison URL. |
Finished benchmarking try commit (0e02f3685d46b23771eab0f3e32ad5c642674b72): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 5c07b11d3f4f488fa22cd84f9cb7896b7d5510c1 with merge 8a56338175f5895c206e36b88ef2a54b7431ba55... |
☀️ Try build successful - checks-actions |
Queued 8a56338175f5895c206e36b88ef2a54b7431ba55 with parent 9503ea1, future comparison URL. |
Finished benchmarking try commit (8a56338175f5895c206e36b88ef2a54b7431ba55): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
7fd72a8
to
f32efec
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit f32efec494af50c0af25fd141126b1c3b553a4fd with merge 94eba4a15a544415ce0127f932e91a67230e460d... |
☀️ Try build successful - checks-actions |
⌛ Testing commit f2da425 with merge fe6b31cd5e1d5b2c089f6f3f242c3c925062a079... |
💥 Test timed out |
@bors retry |
⌛ Testing commit f2da425 with merge 2ce5bf004705ce261a9be0a58352a86269dacf3d... |
💥 Test timed out |
@bors retry |
☀️ Test successful - checks-actions |
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot)
|
r? @ghost