Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass large interpreter types by reference, not value #82124

Merged
merged 6 commits into from
Feb 20, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Feb 15, 2021

r? @ghost

@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 15, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 15, 2021
@bors
Copy link
Contributor

bors commented Feb 15, 2021

⌛ Trying commit 2f848d16c713221f16669cdc9f26e3475f0e853f with merge 0e02f3685d46b23771eab0f3e32ad5c642674b72...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Feb 15, 2021

☀️ Try build successful - checks-actions
Build commit: 0e02f3685d46b23771eab0f3e32ad5c642674b72 (0e02f3685d46b23771eab0f3e32ad5c642674b72)

@rust-timer
Copy link
Collaborator

Queued 0e02f3685d46b23771eab0f3e32ad5c642674b72 with parent 9503ea1, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (0e02f3685d46b23771eab0f3e32ad5c642674b72): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 15, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 15, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 15, 2021
@bors
Copy link
Contributor

bors commented Feb 15, 2021

⌛ Trying commit 5c07b11d3f4f488fa22cd84f9cb7896b7d5510c1 with merge 8a56338175f5895c206e36b88ef2a54b7431ba55...

@bors
Copy link
Contributor

bors commented Feb 15, 2021

☀️ Try build successful - checks-actions
Build commit: 8a56338175f5895c206e36b88ef2a54b7431ba55 (8a56338175f5895c206e36b88ef2a54b7431ba55)

@rust-timer
Copy link
Collaborator

Queued 8a56338175f5895c206e36b88ef2a54b7431ba55 with parent 9503ea1, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (8a56338175f5895c206e36b88ef2a54b7431ba55): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 15, 2021
@tmiasko tmiasko force-pushed the op-ty-ref branch 2 times, most recently from 7fd72a8 to f32efec Compare February 15, 2021 18:22
@tmiasko tmiasko changed the title OpTy has 80 bytes, pass it around by reference not value Pass large interpreter types by reference, not value Feb 15, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 15, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 15, 2021
@bors
Copy link
Contributor

bors commented Feb 15, 2021

⌛ Trying commit f32efec494af50c0af25fd141126b1c3b553a4fd with merge 94eba4a15a544415ce0127f932e91a67230e460d...

@bors
Copy link
Contributor

bors commented Feb 15, 2021

☀️ Try build successful - checks-actions
Build commit: 94eba4a15a544415ce0127f932e91a67230e460d (94eba4a15a544415ce0127f932e91a67230e460d)

@RalfJung RalfJung mentioned this pull request Feb 18, 2021
@bors
Copy link
Contributor

bors commented Feb 18, 2021

⌛ Testing commit f2da425 with merge fe6b31cd5e1d5b2c089f6f3f242c3c925062a079...

@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 18, 2021

@RalfJung I can make the appropriate changes in miri after this lands.

It appears the CI will time out on i686-gnu-nopt builder once again #82221, though :-(.

@bors
Copy link
Contributor

bors commented Feb 18, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 18, 2021
@RalfJung
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Feb 19, 2021

⌛ Testing commit f2da425 with merge 2ce5bf004705ce261a9be0a58352a86269dacf3d...

@camelid camelid added the A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) label Feb 19, 2021
@bors
Copy link
Contributor

bors commented Feb 20, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 20, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@RalfJung
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 20, 2021
@bors
Copy link
Contributor

bors commented Feb 20, 2021

⌛ Testing commit f2da425 with merge e7c23ab...

@bors
Copy link
Contributor

bors commented Feb 20, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing e7c23ab to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 20, 2021
@bors bors merged commit e7c23ab into rust-lang:master Feb 20, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 20, 2021
@tmiasko tmiasko deleted the op-ty-ref branch February 20, 2021 13:09
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at e7c23ab93 Auto merge of #82124 - tmiasko:op-ty-ref, r=oli-obk
##[group]Run src/ci/publish_toolstate.sh
src/ci/publish_toolstate.sh
env:
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  DEPLOY_BUCKET: rust-lang-ci2
  TOOLSTATE_REPO: https://github.com/rust-lang-nursery/rust-toolstate
---
  CACHE_DOMAIN: ci-caches.rust-lang.org
  TOOLSTATE_REPO_ACCESS_TOKEN: ***
##[endgroup]
Cloning into 'rust-toolstate'...
/home/runner/work/rust/rust/src/tools/publish_toolstate.py:121: DeprecationWarning: 'U' mode is deprecated
📣 Toolstate changed by rust-lang/rust#82124!
  with open(path, 'rU') as f:

Tested on commit rust-lang/rust@e7c23ab933ebc1f205c3b59f4ebc85d40f67d404.
Direct link to PR: <https://github.com/rust-lang/rust/pull/82124>

💔 miri on windows: test-fail → build-fail (cc @RalfJung @eddyb @oli-obk).
💔 miri on linux: test-fail → build-fail (cc @RalfJung @eddyb @oli-obk).
Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/runner/work/rust/rust/src/tools/publish_toolstate.py", line 338, in <module>
    response = urllib2.urlopen(urllib2.Request(
  File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.8/urllib/request.py", line 522, in open
    req = meth(req)
  File "/usr/lib/python3.8/urllib/request.py", line 1281, in do_request_
    raise TypeError(msg)
TypeError: POST data should be bytes, an iterable of bytes, or a file object. It cannot be of type str.
##[error]Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants